Structured Logs: Buffering & flushing of logs #5628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denrase
changed the title
denrase
requested review from
philipphofmann,
armcknight,
philprime,
noahsmartin and
itaybre
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5628 +/- ##
=============================================
+ Coverage 86.631% 86.692% +0.061%
=============================================
Files 419 419
Lines 35717 35808 +91
Branches 16869 16921 +52
=============================================
+ Hits 30942 31043 +101
+ Misses 4731 4723 -8
+ Partials 44 42 -2
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
| 2481950 | 1221.04 ms | 1248.98 ms | 27.94 ms |
| e3ebff3 | 1223.47 ms | 1249.27 ms | 25.80 ms |
| 30f4e4c | 1213.21 ms | 1250.29 ms | 37.08 ms |
| fc0757d | 1231.83 ms | 1248.98 ms | 17.15 ms |
| 7148f97 | 1235.09 ms | 1258.07 ms | 22.98 ms |
| 4e3915a | 1230.02 ms | 1258.90 ms | 28.88 ms |
| 7d23639 | 1237.93 ms | 1243.04 ms | 5.11 ms |
| aa96485 | 1215.37 ms | 1234.04 ms | 18.67 ms |
| a9fac2e | 1212.45 ms | 1219.67 ms | 7.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 2481950 | 23.74 KiB | 872.74 KiB | 849.00 KiB |
| e3ebff3 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
| 30f4e4c | 23.75 KiB | 879.24 KiB | 855.50 KiB |
| fc0757d | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 7148f97 | 23.75 KiB | 854.78 KiB | 831.03 KiB |
| 4e3915a | 23.75 KiB | 858.69 KiB | 834.94 KiB |
| 7d23639 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
| aa96485 | 23.75 KiB | 874.46 KiB | 850.71 KiB |
| a9fac2e | 23.75 KiB | 879.53 KiB | 855.78 KiB |
Previous results on branch: feat/structured-logs-batcher
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 023fb2c | 1216.98 ms | 1243.15 ms | 26.17 ms |
| 482b03d | 1230.06 ms | 1250.23 ms | 20.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 023fb2c | 23.75 KiB | 893.04 KiB | 869.29 KiB |
| 482b03d | 23.75 KiB | 901.08 KiB | 877.34 KiB |
itaybre
reviewed
Jul 15, 2025
itaybre
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Thanks for doing this @denrase, but I found some issues. It could be that the develop docs in https://develop.sentry.dev/sdk/telemetry/spans/batch-processor/#specification need some clarification. Please let me know if they aren't clear enough and I will update them.
philipphofmann
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
One final comment to address. Thank you @denrase. Then LGTM.
# Conflicts: # Sources/Swift/Tools/SentryLogBatcher.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Implements batching of logs.
💡 Motivation and Context
Closes #5580
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.